linux-kernel - Re: [PATCH 2/2] phy: berlin-usb: don't set device's driver_data

Open Source and information security mailing list archives

Message-ID: <20151204210919.GB7200@kwain>
Date:	Fri, 4 Dec 2015 22:09:19 +0100
From:	Antoine Tenart <antoine.tenart@...e-electrons.com>
To:	Jisheng Zhang <jszhang@...vell.com>
Cc:	kishon@...com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] phy: berlin-usb: don't set device's driver_data

On Fri, Dec 04, 2015 at 09:57:01PM +0800, Jisheng Zhang wrote:
> After commit 739ae3452d0e ("phy: berlin-usb: Set drvdata for phy and
> use it"), we get the address of priv by phy_get_drvdata(), so there's
> no need to set device's driver_data any more. This patch removes the
> call of platform_set_drvdata().
> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>

Acked-by: Antoine Tenart <antoine.tenart@...e-electrons.com>

> ---
>  drivers/phy/phy-berlin-usb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 7bbb473..2017751 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -193,7 +193,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
>  		return PTR_ERR(phy);
>  	}
>  
> -	platform_set_drvdata(pdev, priv);
>  	phy_set_drvdata(phy, priv);
>  
>  	phy_provider =
> -- 
> 2.6.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives