linux-kernel - Re: [PATCH (v2) 1/2] reset: Add brcm,bcm6345-reset device tree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a3790afc811ac4ed732371f2eb33a7c194b996d@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid>
Date:	Fri, 4 Dec 2015 21:12:10 -0000
From:	"Simon Arlott" <simon@...e.lp0.eu>
To:	"Rob Herring" <robh+dt@...nel.org>,
	"Philipp Zabel" <p.zabel@...gutronix.de>
Cc:	"Kevin Cernekee" <cernekee@...il.com>,
	"Florian Fainelli" <f.fainelli@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	"MIPS Mailing List" <linux-mips@...ux-mips.org>,
	"Pawel Moll" <pawel.moll@....com>,
	"Mark Rutland" <mark.rutland@....com>,
	"Ian Campbell" <ijc+devicetree@...lion.org.uk>,
	"Sergei Shtylyov" <sergei.shtylyov@...entembedded.com>
Subject: Re: [PATCH (v2) 1/2] reset: Add brcm,bcm6345-reset device tree
 binding

On Thu, December 3, 2015 08:39, Philipp Zabel wrote:
> Am Mittwoch, den 02.12.2015, 21:03 +0000 schrieb Simon Arlott:
>> +periph_soft_rst: reset-controller {
>> +	compatible = "brcm,bcm63168-reset", "brcm,bcm6345-reset";
>> +	regmap = <&periph_cntl>;
>> +	offset = <0x10>;
>> +
>> +	#reset-cells = <1>;
>> +};
>
> I would have written it something like this:
>
> periph_cntl: ... {
> 	compatible = "syscon", "simple-mfd";
> 	#address-cells = <1>;
> 	#size-cells = <1>;
>
> 	periph_soft_rst: reset-controller {
> 		compatible = "brcm,bcm6345-reset";
> 		reg = <0x10 0x4>;
> 		#reset-cells = <1>;
> 	};
> };
>
> for a device that is only controlled through a syscon.

Rob, do you want me to change this or is my version ok?

> The driver itself looks good to me.
>
> best regards
> Philipp
>
>

-- 
Simon Arlott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/