linux-kernel - Re: [PATCH v2 0/3] Fixes for twl4030 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 5 Dec 2015 00:54:42 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	"H. Nikolaus Schaller" <hns@...delico.com>
Cc:	Gražvydas Ignotas <notasas@...il.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Andreas Kemnade <andreas@...nade.info>,
	linux-pm@...r.kernel.org, gta04-owner@...delico.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Fixes for twl4030 charger

Hi Nikolaus,

On Mon, Nov 02, 2015 at 12:27:33PM +0100, H. Nikolaus Schaller wrote:
> Changes V2:
> * worked in comments by Nishanth Menon <nm@...com>
> * added another patch which solves a probing/boot stall problem (irq allocation vs. -EPROBE_DEFER)
> 
> V1:
> 4.3-rc1 introduced a new charger driver for the twl4030.
> 
> While making it operable and testing on GTA04 and OpenPandora
> we have found some issues.
> 
> 
> H. Nikolaus Schaller (3):
>   drivers:power:twl4030-charger: fix problem with EPROBE_DEFER
>   drivers:power:twl4030-charger: don't return after allocating irq
>   drivers:power:twl4030-charger: don't check if battery is present

PATCH 1 and 2 should be rebased to my current next branch.
They definetly do not take 2202e1fc5a into account. Also
take into account, that iio_channel_get() is not managed,
so you will have to free the channel, if your return an
error after it.

PATCH 3 introduces a new warning:

drivers/power/twl4030_charger.c:211:12: warning: ‘twl4030_is_battery_present’ defined but not used [-Wunused-function]

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)