linux-kernel - Re: [PATCH] iio: st_accel_core: Remove unneeded define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56631EE4.7080002@kernel.org>
Date:	Sat, 5 Dec 2015 17:29:08 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Robert Kmiec <robert.r.kmiec@...il.com>, knaack.h@....de,
	lars@...afoo.de, pmeerw@...erw.net, denis.ciocca@...com,
	linus.walleij@...aro.org, giuseppe.barba@...com,
	alban.bedel@...onic-design.de, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: st_accel_core: Remove unneeded define

On 03/12/15 23:54, Robert Kmiec wrote:
> Definition of ST_SENSORS_WAI_ADDRESS was introduced within a very
> first commit of this driver, but it was never used.
> This address is already defined as ST_SENSORS_DEFAULT_WAI_ADDRESS
> in include/linux/iio/common/st_sensors.h
> 
> To avoid duplication of the same constant in two different places
> called almost exactly the same, the one which was never used
> should be removed.
> 
> Signed-off-by: Robert Kmiec <robert.r.kmiec@...il.com>
Fair enough.

Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/common/st_sensors/st_sensors_core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
> index 25258e2..8447c31 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -18,9 +18,6 @@
>  #include <asm/unaligned.h>
>  #include <linux/iio/common/st_sensors.h>
>  
> -
> -#define ST_SENSORS_WAI_ADDRESS		0x0f
> -
>  static inline u32 st_sensors_get_unaligned_le24(const u8 *p)
>  {
>  	return (s32)((p[0] | p[1] << 8 | p[2] << 16) << 8) >> 8;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/