linux-kernel - Re: [PATCH LINUX v3 00/10] tty: xuartps: Fix lock ups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151205220236.GO4900@xsjsorenbubuntu>
Date:	Sat, 5 Dec 2015 14:02:36 -0800
From:	Sören Brinkmann <soren.brinkmann@...inx.com>
To:	Peter Hurley <peter@...leysoftware.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	Michal Simek <michal.simek@...inx.com>,
	<linux-serial@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH LINUX v3 00/10] tty: xuartps: Fix lock ups

On Sat, 2015-12-05 at 12:49PM -0500, Peter Hurley wrote:
> On 11/21/2015 09:59 PM, Soren Brinkmann wrote:
> > Hi,
> > 
> > here is v3 of this series. It's largely the same as before, but I
> > adjusted 'tty: xuartps: Don't consider circular buffer when enabling
> > transmitter' according to Peter's suggestions.
> 
> In reviewing this series, I thought the _OFFSET suffix for every register
> address to be excessive. I would refactor all that out; IOW,
> 
> -	isrstatus = readl(port->membase + CDNS_UART_ISR_OFFSET);
> +	isrstatus = readl(port->membase + CDNS_UART_ISR);

I'll add that as a patch on top of everything.

> 
> 
> > I also spent some time trying to get Peter's test for flow control and
> > xchar running. The xchar thing fails and will need some more work, but I
> > think in general it should be possible to get it to work.
> > The flow control test passes:
> > 
> > root@...inx-ZC1751-DC1:~# ./flow /dev/ttyPS0
> > Test flow control on /dev/ttyPS0
> > begin test1
> > patterns sent: 223  recvd: 208
> > read distribution: 1   = 0
> >                    2+  = 0
> >                    4+  = 0
> >                    8+  = 0
> >                   16+  = 0
> >                   32+  = 643
> >                   64+  = 0
> >                  128+  = 0
> >                  256+  = 0
> >                  512+  = 0
> > PASSED
> 
> This distribution looks like this exactly because the xchar test is
> failing. IOW, this driver isn't performing soft flow control (^S,^Q)
> like it should.

I tried to the your xchar test working, but so far that failed. I'll try
to spend some more time on this.

	Thanks,
	Sören
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/