linux-kernel - Re: [PATCH V2] goldfish: add goldfish match node for dt driver probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151205011313.GG22936@earth>
Date:	Sat, 5 Dec 2015 02:13:13 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	yalin wang <yalin.wang2010@...il.com>
Cc:	dmitry.torokhov@...il.com, dbaryshkov@...il.com,
	dwmw2@...radead.org, gregkh@...uxfoundation.org, jslaby@...e.com,
	plagnioj@...osoft.com, tomi.valkeinen@...com,
	peter.senna@...il.com, dan.carpenter@...cle.com, joe@...ches.com,
	alan@...ux.intel.com, somyaanand214@...il.com,
	ricardo.ribalda@...il.com, mahfouz.saif.elyazal@...il.com,
	ravi2j@...il.com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH V2] goldfish: add goldfish match node for dt driver probe

Hi,

On Fri, Nov 06, 2015 at 03:12:40PM +0800, yalin wang wrote:
> qemu use device tree to bootup linux kernel,
> we need add device node match table to plaftorm driver,
> so that can probe the goldfish driver correctly.
> test by this qemu:
> git clone https://android.googlesource.com/platform/external/qemu

Your patch is missing the DT binding documentation part and should
be splitted into multiple patches, at least one per kernel
subsystem. Please read Documentation/SubmittingPatches and
Documentation/devicetree/bindings/submitting-patches.txt

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)