linux-kernel - Re: [PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151207.162802.462148155042537146.davem@davemloft.net>
Date:	Mon, 07 Dec 2015 16:28:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sowmini.varadhan@...cle.com
Cc:	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com, shannon.nelson@...el.com,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	matthew.vick@...el.com, john.ronciak@...el.com,
	mitch.a.williams@...el.com, andy.shevchenko@...il.com
Subject: Re: [PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Mon, 7 Dec 2015 15:06:34 -0500

> This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC
> address in Open Firmware or IDPROM").
> 
> As with that fix, attempt to look up the MAC address in Open Firmware
> on systems that support it, and use IDPROM on SPARC if no OF address
> is found.
> 
> In the case of the i40e there is an assumption that the default mac
> address has already been set up as the primary mac filter on probe,
> so if this filter is obtained from the Open Firmware or IDPROM, an
> explicit write is needed via i40e_aq_mac_address_write() and
> i40e_aq_add_macvlan() invocation.
> 
> The I40E_FLAG_PF_MAC flag in the platform-private i40e_pf structure
> tracks whether a platform-specific mac address was found, in which
> case calls to i40e_aq_mac_address_write() and i40e_aq_add_macvlan()
> will be triggered.
> 
> Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>

This looks good to me.

Once this goes in I'll add my generic MAC stuff to net-next and then
we can convert the various Intel drivers to use it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/