linux-kernel - Re: [PATCH 12/23] mtd: use mtd_eccpos() and mtd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Dec 2015 06:48:53 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:	kbuild-all@...org, David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	linux-mtd@...ts.infradead.org, devel@...verdev.osuosl.org,
	linux-mips@...ux-mips.org,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-samsung-soc@...r.kernel.org,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-sunxi@...glegroups.com, Ralf Baechle <ralf@...ux-mips.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	linux-kernel@...r.kernel.org, Josh Wu <josh.wu@...el.com>,
	Chen-Yu Tsai <wens@...e.org>, Kukjin Kim <kgene@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	punnaiah choudary kalluri <punnaia@...inx.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Stefan Agner <stefan@...er.ch>, Daniel Mack <daniel@...que.org>
Subject: Re: [PATCH 12/23] mtd: use mtd_eccpos() and mtd_oobfree() where
 appropriate

Hi Boris,

[auto build test ERROR on next-20151207]
[cannot apply to staging/staging-testing v4.4-rc4 v4.4-rc3 v4.4-rc2 v4.4-rc4]

url:    https://github.com/0day-ci/linux/commits/Boris-Brezillon/mtd-rework-ECC-layout-definition/20151208-063127
config: i386-randconfig-x006-12070758 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from drivers/mtd/mtdswap.c:27:
   drivers/mtd/mtdswap.c: In function 'mtdswap_add_mtd':
>> drivers/mtd/mtdswap.c:1449:6: error: too few arguments to function 'mtd_oobfree'
     if (mtd_oobfree(mtd, 0) < 0) {
         ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^
>> drivers/mtd/mtdswap.c:1449:2: note: in expansion of macro 'if'
     if (mtd_oobfree(mtd, 0) < 0) {
     ^
   In file included from drivers/mtd/mtdswap.c:29:0:
   include/linux/mtd/mtd.h:267:19: note: declared here
    static inline int mtd_oobfree(struct mtd_info *mtd, int section,
                      ^
   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from drivers/mtd/mtdswap.c:27:
>> drivers/mtd/mtdswap.c:1449:6: error: too few arguments to function 'mtd_oobfree'
     if (mtd_oobfree(mtd, 0) < 0) {
         ^
   include/linux/compiler.h:147:40: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                                           ^
>> drivers/mtd/mtdswap.c:1449:2: note: in expansion of macro 'if'
     if (mtd_oobfree(mtd, 0) < 0) {
     ^
   In file included from drivers/mtd/mtdswap.c:29:0:
   include/linux/mtd/mtd.h:267:19: note: declared here
    static inline int mtd_oobfree(struct mtd_info *mtd, int section,
                      ^
   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from drivers/mtd/mtdswap.c:27:
>> drivers/mtd/mtdswap.c:1449:6: error: too few arguments to function 'mtd_oobfree'
     if (mtd_oobfree(mtd, 0) < 0) {
         ^
   include/linux/compiler.h:158:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^
>> drivers/mtd/mtdswap.c:1449:2: note: in expansion of macro 'if'
     if (mtd_oobfree(mtd, 0) < 0) {
     ^
   In file included from drivers/mtd/mtdswap.c:29:0:
   include/linux/mtd/mtd.h:267:19: note: declared here
    static inline int mtd_oobfree(struct mtd_info *mtd, int section,
                      ^

vim +/mtd_oobfree +1449 drivers/mtd/mtdswap.c

  1443		if (PAGE_SIZE % mtd->writesize || mtd->writesize > PAGE_SIZE) {
  1444			printk(KERN_ERR "%s: PAGE_SIZE %lu not multiple of write size"
  1445				" %u\n", MTDSWAP_PREFIX, PAGE_SIZE, mtd->writesize);
  1446			return;
  1447		}
  1448	
> 1449		if (mtd_oobfree(mtd, 0) < 0) {
  1450			printk(KERN_ERR "%s: mtd%d does not have OOB\n",
  1451				MTDSWAP_PREFIX, mtd->index);
  1452			return;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (26343 bytes)