linux-kernel - Re: [PATCH] infiniband:core:Add needed error path in cm_init_av_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR05MB13551694F8428E5A53CB3993C1090@HE1PR05MB1355.eurprd05.prod.outlook.com>
Date:	Mon, 7 Dec 2015 07:57:33 +0000
From:	Haggai Eran <haggaie@...lanox.com>
To:	Nicholas Krause <xerofoify@...il.com>,
	"dledford@...hat.com" <dledford@...hat.com>
CC:	"sean.hefty@...el.com" <sean.hefty@...el.com>,
	"hal.rosenstock@...il.com" <hal.rosenstock@...il.com>,
	"jgunthorpe@...idianresearch.com" <jgunthorpe@...idianresearch.com>,
	Matan Barak <matanb@...lanox.com>,
	"yun.wang@...fitbricks.com" <yun.wang@...fitbricks.com>,
	"ted.h.kim@...cle.com" <ted.h.kim@...cle.com>,
	Doron Tsur <doront@...lanox.com>,
	Erez Shitrit <erezsh@...lanox.com>,
	"david.ahern@...cle.com" <david.ahern@...cle.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] infiniband:core:Add needed error path in
 cm_init_av_by_path

On Friday, December 4, 2015 8:02 PM, Nicholas Krause <xerofoify@...il.com> wrote:
> To: dledford@...hat.com
> Cc: sean.hefty@...el.com; hal.rosenstock@...il.com; Haggai Eran; jgunthorpe@...idianresearch.com; Matan Barak; yun.wang@...fitbricks.com; ted.h.kim@...cle.com; Doron Tsur; Erez Shitrit; david.ahern@...cle.com; linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path
> 
> This adds a needed error path in the function, cm_init_av_by_path
> after the call to ib_init_ah_from_path in order to avoid incorrectly
> accessing the path pointer of structure type ib_sa_path_rec if this
> function call fails to complete its intended work successfully by
> returning a error code.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>

The subject doesn't seem to match the convention but apart from that,

Reviewed-by: Haggai Eran <haggaie@...lanox.com>

I wonder if this should go to stable. If I understand correctly, this will fail only when the SGID isn't found in the GID table, but such connections would fail later on when creating a QP, right?

Haggai--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/