linux-kernel - Re: [PATCH/RESEND] ARM: dts: kirkwood: Add DTS for Zyxel NSA325

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151207014110.GB19715@lunn.ch>
Date:	Mon, 7 Dec 2015 02:41:10 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Hans Ulli Kroll <ulli.kroll@...glemail.com>
Cc:	Gregory Clement <gregory.clement@...e-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH/RESEND] ARM: dts: kirkwood: Add DTS for Zyxel NSA325

> +		serial@...00 {
> +			status = "ok";
> +		};
> +
> +		sata@...00 {
> +			status = "okay";
> +			nr-ports = <2>;
> +		};
> +	};
> +
> +		gpio-leds {
> +		compatible = "gpio-leds";
> +		pinctrl-0 = <&pmx_led_hdd2_green &pmx_led_hdd2_red
> +			     &pmx_led_usb_green
> +			     &pmx_led_sys_green &pmx_led_sys_orange
> +			     &pmx_led_copy_green &pmx_led_copy_red
> +			     &pmx_led_hdd1_green &pmx_led_hdd1_red>;
> +		pinctrl-names = "default";

Hi Hans

There is some odd indentation going on here, and in other parts of the
file.

> +
> +&nand {
> +	status = "okay";
> +	chip-delay = <35>;
> +
> +	partition@0 {
> +		label = "uboot";
> +		reg = <0x0000000 0x0100000>;
> +	};

The partitions should be inside a partitions node. See
Documentation/devicetree/bindings/mtd/partition.txt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/