linux-kernel - Re: [PATCH 3/4] x86/cpufeature: Remove unused and seldomly used cpu_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Dec 2015 10:54:20 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] x86/cpufeature: Remove unused and seldomly used
 cpu_has_xx macros

On Mon, Dec 07, 2015 at 10:45:04AM +0100, Ingo Molnar wrote:
> 
> * Borislav Petkov <bp@...en8.de> wrote:
> 
> >  static int __init chacha20_simd_mod_init(void)
> >  {
> > -	if (!cpu_has_ssse3)
> > +	if (!boot_cpu_has(X86_FEATURE_SSSE3))
> >  		return -ENODEV;
> 
> Btw., could we rename 'boot_cpu_has()' to the more appropriate (and shorter!) 
> 'system_has()' form?
> 
> 'boot cpu' is a conceptual misnomer here really: it's just an implementational 
> detail that we are looking at the boot CPU's flags, what we really mean to express 
> is that these are system-wide features with no per-cpu properties.
> 
> Agreed?

Yeah, sounds good to me.

Mind if I do it for the next part of the cleanup, though, and not rework
those patches which are already tested?

I have a bunch of bulletpoints on the TODO still and could take care of
the renaming then too.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/