linux-kernel - Re: [PATCH] ia64: bitvector_process could read out of bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+MoWDry0k11Xvmj46iUBqK4Zx19MpStZUa=ZJmf8JnyOkNt+w@mail.gmail.com>
Date:	Mon, 7 Dec 2015 11:07:18 +0100
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	João Guilherme Victorino <jg.victorino1@...il.com>,
	raphaelscarv@...il.com, Tony Luck <tony.luck@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>, linux-ia64@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ia64: bitvector_process could read out of bounds

On Wed, Dec 2, 2015 at 8:07 PM, Geyslan G. Bem <geyslan@...il.com> wrote:
> The units[] array could be accessed out of its bounds due the lack of
> verification of the max vector value.
>
> To make this function not prone to error "P" and "E" suffixes were added.
> Despite the new suffixes are unrelated to current ia64 vm magnitudes, they
> make the code ready for it and avoid misleadings.

I would mention that you also fix some white space issues, but other than that:

Acked-by: Peter Senna Tschudin <peter.senna@...il.com>
>
> Catched using static analysis (cppcheck).
>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>

> ---
>  arch/ia64/kernel/palinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/ia64/kernel/palinfo.c b/arch/ia64/kernel/palinfo.c
> index c39c3cd..160aba1 100644
> --- a/arch/ia64/kernel/palinfo.c
> +++ b/arch/ia64/kernel/palinfo.c
> @@ -126,7 +126,7 @@ static const char *mem_attrib[]={
>  static void bitvector_process(struct seq_file *m, u64 vector)
>  {
>         int i,j;
> -       static const char *units[]={ "", "K", "M", "G", "T" };
> +       static const char *units[] = { "", "K", "M", "G", "T", "P", "E" };
>
>         for (i=0, j=0; i < 64; i++ , j=i/10) {
>                 if (vector & 0x1)
> --
> 2.6.2
>



-- 
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/