linux-kernel - Re: [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xk2oqo6lm.fsf@unicorn.mansr.com>
Date:	Mon, 07 Dec 2015 11:12:21 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA

Geert Uytterhoeven <geert@...ux-m68k.org> writes:

> If NO_DMA=y:
>
>     ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Mans Rullgard <mans@...sr.com>

>  drivers/net/ethernet/aurora/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/aurora/Kconfig b/drivers/net/ethernet/aurora/Kconfig
> index a3c7106fdf85e78f..8ba7f8ff3434000f 100644
> --- a/drivers/net/ethernet/aurora/Kconfig
> +++ b/drivers/net/ethernet/aurora/Kconfig
> @@ -13,6 +13,7 @@ if NET_VENDOR_AURORA
>
>  config AURORA_NB8800
>  	tristate "Aurora AU-NB8800 support"
> +	depends on HAS_DMA
>  	select PHYLIB
>  	help
>  	 Support for the AU-NB8800 gigabit Ethernet controller.
> -- 
> 1.9.1
>

-- 
Måns Rullgård
mans@...sr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/