linux-kernel - Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1720878.JdEcLd8bhL@wuerfel>
Date:	Mon, 07 Dec 2015 12:13:55 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Jon Hunter <jonathanh@...dia.com>
Cc:	Daniel Cashman <dcashman@...roid.com>,
	linux-kernel@...r.kernel.org, dcashman@...gle.com,
	linux-doc@...r.kernel.org, catalin.marinas@....com,
	will.deacon@....com, linux-mm@...ck.org, hpa@...or.com,
	mingo@...nel.org, aarcange@...hat.com, linux@....linux.org.uk,
	corbet@....net, xypron.glpk@....de, x86@...nel.org,
	hecmargi@....es, mgorman@...e.de, rientjes@...gle.com, bp@...e.de,
	nnk@...gle.com, dzickus@...hat.com, keescook@...omium.org,
	jpoimboe@...hat.com, tglx@...utronix.de, n-horiguchi@...jp.nec.com,
	linux-arm-kernel@...ts.infradead.org, salyzyn@...roid.com,
	ebiederm@...ssion.com, jeffv@...gle.com, akpm@...ux-foundation.org,
	kirill.shutemov@...ux.intel.com
Subject: Re: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

On Monday 07 December 2015 10:26:16 Jon Hunter wrote:
> 
> diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
> index af461b935137..e59a75a308bc 100644
> --- a/arch/arm64/mm/mmap.c
> +++ b/arch/arm64/mm/mmap.c
> @@ -51,7 +51,7 @@ unsigned long arch_mmap_rnd(void)
>  {
>         unsigned long rnd;
>  
> -ifdef CONFIG_COMPAT
> +#ifdef CONFIG_COMPAT
>         if (test_thread_flag(TIF_32BIT))
>                 rnd = (unsigned long)get_random_int() % (1 << mmap_rnd_compat_bits);
>         else
> 
> Cheers
> 

Ideally we'd remove the #ifdef around the mmap_rnd_compat_bits declaration
and change this code to use

	if (IS_ENABLED(CONFIG_COMPAT) && test_thread_flag(TIF_32BIT))

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/