[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5665AB03.3000304@nvidia.com>
Date: Mon, 7 Dec 2015 10:51:31 -0500
From: Rhyland Klein <rklein@...dia.com>
To: Jon Hunter <jonathanh@...dia.com>,
Peter De Schrijver <pdeschrijver@...dia.com>,
Prashant Gaikwad <pgaikwad@...dia.com>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...eaurora.org>,
Stephen Warren <swarren@...dotorg.org>,
Thierry Reding <thierry.reding@...il.com>,
Alexandre Courbot <gnurou@...il.com>
CC: <linux-clk@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] clk: tegra210: Fix sparse warnings for functions not
declared as static
On 12/4/2015 12:04 PM, Jon Hunter wrote:
> Sparse reports the following warnings for functions in clk-tegra210.c
> that should be declared as static:
>
> drivers/clk/tegra/clk-tegra210.c:460:6: warning: symbol
> 'tegra210_pllcx_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:485:6: warning: symbol
> '_pllc_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:490:6: warning: symbol
> '_pllc2_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:495:6: warning: symbol
> '_pllc3_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:500:6: warning: symbol
> '_plla1_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:510:6: warning: symbol
> 'tegra210_plla_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:562:6: warning: symbol
> 'tegra210_plld_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:701:6: warning: symbol
> 'tegra210_plld2_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:709:6: warning: symbol
> 'tegra210_plldp_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:722:6: warning: symbol
> 'tegra210_pllc4_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:731:6: warning: symbol
> 'tegra210_pllre_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:844:6: warning: symbol
> 'tegra210_pllx_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:904:6: warning: symbol
> 'tegra210_pllmb_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:963:6: warning: symbol
> 'tegra210_pllp_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:1025:6: warning: symbol
> 'tegra210_pllu_set_defaults' was not declared. Should it be static?
> drivers/clk/tegra/clk-tegra210.c:1215:15: warning: symbol
> 'tegra210_clk_adjust_vco_min' was not declared. Should it be static?
>
> Fix this by declaring the above as static.
>
> Fixes: b31eba5ff3f7 ("clk: tegra: Add support for Tegra210 clocks")
>
> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
> ---
> drivers/clk/tegra/clk-tegra210.c | 36 +++++++++++++++++++-----------------
> 1 file changed, 19 insertions(+), 17 deletions(-)
...
Acked-by: Rhyland Klein <rklein@...dia.com>
--
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists