linux-kernel - Re: [PATCH] Staging: Skein: Patch adds the test vectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151207061605.GC4122@sudip-pc>
Date:	Mon, 7 Dec 2015 11:46:05 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Sanidhya Solanki <jpage.lkml@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	jason@...edaemon.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: Skein: Patch adds the test vectors

On Sat, Dec 05, 2015 at 06:44:10AM -0500, Sanidhya Solanki wrote:
> The patch is included below.
> I would like to apologize for the past few emails. It turns out the
> documentation included in the eMail clients file is woefully out of
> date. I have checked the patches for errors using the scripts provided.
> However, it turns out that the scripts are slightly incorrect, as you
> can see when it keeps asking to align the statements with the brackets.
> Another issue has turned out to be that you cannot follow the scripts
> completely without altering the code in a significant way, as it
> suggests changing the deterministic portions of the hash, changing
> certain functions, reducing line length, etc.
> I have sent the patch to myself, applied it, as well as compared sha512
> hashes of both the original and the mailed copy.
> For the rest of the work on this patch and the skein subsystem, I defer
> to someone with the expertise and experience of making Linux modules
> and the skein hash families. I believe that if I continue to make
> further changes to these files, I might make a mistake which alters
> functionality of the hash function. I will continue to contribute to
> the other kernel branches.
> I will submit a patch to correct the email documentation tomorrow. 
> Thanks for you patience everyone.
> -----------------------------------------------------------------------

This should not be part of commit message. If you have to write
something then it should go in the comments section. And please test
your patch with checkpatch (preferably with --strict)  before sending.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/