linux-kernel - Re: [RFC][PATCH -reworked] time: Verify time values in adjtimex ADJ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLU6xAftp7S=PgHKY40hjq93pXCRAG6gfqyzvrgQqkv7yQ@mail.gmail.com>
Date:	Mon, 7 Dec 2015 12:13:27 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	lkml <linux-kernel@...r.kernel.org>
Cc:	Sasha Levin <sasha.levin@...cle.com>,
	Richard Cochran <richardcochran@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>
Subject: Re: [RFC][PATCH -reworked] time: Verify time values in adjtimex
 ADJ_SETOFFSET to avoid overflow

On Mon, Dec 7, 2015 at 12:11 PM, John Stultz <john.stultz@...aro.org> wrote:
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index 99188ee..a37222b 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -1986,6 +1986,7 @@ int do_adjtimex(struct timex *txc)
>
>         if (txc->modes & ADJ_SETOFFSET) {
>                 struct timespec delta;
> +
>                 delta.tv_sec  = txc->time.tv_sec;
>                 delta.tv_nsec = txc->time.tv_usec;
>                 if (!(txc->modes & ADJ_NANO))

Gah. Except for this needless whitespace. Ignore that please.

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/