linux-kernel - Re: [PATCH] IB/mlx4: use list_for_each_entry_safe in search_relocate_mgid0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151207204452.GB7313@leon.nu>
Date:	Mon, 7 Dec 2015 22:44:52 +0200
From:	Leon Romanovsky <leon@...n.nu>
To:	Geliang Tang <geliangtang@....com>
Cc:	Doug Ledford <dledford@...hat.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IB/mlx4: use list_for_each_entry_safe in
 search_relocate_mgid0_group

On Mon, Dec 07, 2015 at 11:04:43PM +0800, Geliang Tang wrote:
> Simplify the code with list_for_each_entry_safe().
> 
> Signed-off-by: Geliang Tang <geliangtang@....com>
> ---
>  drivers/infiniband/hw/mlx4/mcg.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/mcg.c b/drivers/infiniband/hw/mlx4/mcg.c
> index 99451d8..ebdca2b 100644
> --- a/drivers/infiniband/hw/mlx4/mcg.c
> +++ b/drivers/infiniband/hw/mlx4/mcg.c
> @@ -747,14 +747,11 @@ static struct mcast_group *search_relocate_mgid0_group(struct mlx4_ib_demux_ctx
>  						       __be64 tid,
>  						       union ib_gid *new_mgid)
>  {
> -	struct mcast_group *group = NULL, *cur_group;
> +	struct mcast_group *group = NULL, *cur_group, *n;
>  	struct mcast_req *req;
> -	struct list_head *pos;
> -	struct list_head *n;
>  
>  	mutex_lock(&ctx->mcg_table_lock);
> -	list_for_each_safe(pos, n, &ctx->mcg_mgid0_list) {
> -		group = list_entry(pos, struct mcast_group, mgid0_list);
> +	list_for_each_entry_safe(group, n, &ctx->mcg_mgid0_list, mgid0_list) {
>  		mutex_lock(&group->lock);
>  		if (group->last_req_tid == tid) {
>  			if (memcmp(new_mgid, &mgid0, sizeof mgid0)) {
Thanks,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>

> -- 
> 2.5.0
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/