| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <56668FAC.2000702@samsung.com>
Date: Tue, 08 Dec 2015 17:07:08 +0900
From: Krzysztof Kozlowski <k.kozlowski@...sung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Thomas Abraham <thomas.ab@...sung.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Mike Turquette <mturquette@...aro.org>,
Kukjin Kim <kgene.kim@...sung.com>,
Kukjin Kim <kgene@...nel.org>,
Viresh Kumar <viresh.kumar@...aro.org>,
Ben Gamari <ben@...rt-cactus.org>
Cc: Tomasz Figa <tomasz.figa@...il.com>,
Lukasz Majewski <l.majewski@...sung.com>,
Heiko Stuebner <heiko@...ech.de>,
Chanwoo Choi <cw00.choi@...sung.com>,
Kevin Hilman <khilman@...aro.org>,
Javier Martinez Canillas <javier@....samsung.com>,
Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>,
Anand Moon <linux.amoon@...il.com>,
linux-samsung-soc@...r.kernel.org, linux-pm@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Doug Anderson <dianders@...omium.org>,
Andreas Faerber <afaerber@...e.de>,
Sachin Kamat <sachin.kamat@...aro.org>
Subject: Re: [PATCH v4 6/8] ARM: dts: Exynos5800: fix CPU OPP
On 08.12.2015 03:18, Bartlomiej Zolnierkiewicz wrote:
> Fix CPU operating points for Exynos5800 (it use different
> voltages than Exynos5420 and supports additional frequencies).
> However don't use 2000MHz & 1900MHz OPPs (for A15 cores) and
> 1400MHz OPP (for A7 cores) for now as they are not available
> on all boards.
>
> Based on Hardkernel's kernel for ODROID-XU3 board.
>
> Changes by Ben Gamari:
> - Port to operating-points-v2
>
> Cc: Kukjin Kim <kgene.kim@...sung.com>
> Cc: Doug Anderson <dianders@...omium.org>
> Cc: Javier Martinez Canillas <javier@....samsung.com>
> Cc: Andreas Faerber <afaerber@...e.de>
> Cc: Sachin Kamat <sachin.kamat@...aro.org>
> Cc: Thomas Abraham <thomas.ab@...sung.com>
> Signed-off-by: Ben Gamari <ben@...rt-cactus.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> ---
> arch/arm/boot/dts/exynos5800.dtsi | 165 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 165 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5800.dtsi b/arch/arm/boot/dts/exynos5800.dtsi
> index c0bb356..e417218 100644
> --- a/arch/arm/boot/dts/exynos5800.dtsi
> +++ b/arch/arm/boot/dts/exynos5800.dtsi
> @@ -17,8 +17,173 @@
>
> / {
> compatible = "samsung,exynos5800", "samsung,exynos5";
> +
> + cpu0_opp_table: opp_table0 {
This includes exynos5420.dtsi, so override by label instead of
duplicating full path.
In the same time you don't have to duplicate all data - just override
what you want:
&cpu0_opp_table {
opp00@...0000000 {
opp-microvolt = <1250000>;
};
};
That should be sufficient I think.
> + compatible = "operating-points-v2";
> + opp-shared;
> + opp00@...0000000 {
> + opp-hz = /bits/ 64 <1800000000>;
> + opp-microvolt = <1250000>;
> + clock-latency-ns = <140000>;
> + };
> + opp01@...0000000 {
> + opp-hz = /bits/ 64 <1700000000>;
> + opp-microvolt = <1250000>;
> + clock-latency-ns = <140000>;
> + };
> + opp02@...0000000 {
> + opp-hz = /bits/ 64 <1600000000>;
> + opp-microvolt = <1250000>;
> + clock-latency-ns = <140000>;
> + };
> + opp03@...0000000 {
> + opp-hz = /bits/ 64 <1500000000>;
> + opp-microvolt = <1100000>;
> + clock-latency-ns = <140000>;
> + };
> + opp04@...0000000 {
> + opp-hz = /bits/ 64 <1400000000>;
> + opp-microvolt = <1100000>;
> + clock-latency-ns = <140000>;
> + };
> + opp05@...0000000 {
> + opp-hz = /bits/ 64 <1300000000>;
> + opp-microvolt = <1100000>;
> + clock-latency-ns = <140000>;
> + };
> + opp06@...0000000 {
> + opp-hz = /bits/ 64 <1200000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <140000>;
> + };
> + opp07@...0000000 {
> + opp-hz = /bits/ 64 <1100000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <140000>;
> + };
> + opp08@...0000000 {
> + opp-hz = /bits/ 64 <1000000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <140000>;
> + };
> + opp09@...000000 {
> + opp-hz = /bits/ 64 <900000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <140000>;
> + };
> + opp10@...000000 {
> + opp-hz = /bits/ 64 <800000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <140000>;
> + };
> + opp11@...000000 {
> + opp-hz = /bits/ 64 <700000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <140000>;
> + };
> + opp12@...000000 {
> + opp-hz = /bits/ 64 <600000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <140000>;
> + };
> + opp13@...000000 {
> + opp-hz = /bits/ 64 <500000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <140000>;
> + };
> + opp14@...000000 {
> + opp-hz = /bits/ 64 <400000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <140000>;
> + };
> + opp15@...000000 {
> + opp-hz = /bits/ 64 <300000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <140000>;
> + };
> + opp16@...000000 {
> + opp-hz = /bits/ 64 <200000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <140000>;
> + };
> + };
> +
> + cpu1_opp_table: opp_table1 {
> + compatible = "operating-points-v2";
> + opp-shared;
> + opp00@...0000000 {
> + opp-hz = /bits/ 64 <1300000000>;
> + opp-microvolt = <1250000>;
> + clock-latency-ns = <140000>;
> + };
> + opp01@...0000000 {
> + opp-hz = /bits/ 64 <1200000000>;
> + opp-microvolt = <1250000>;
> + clock-latency-ns = <140000>;
> + };
> + opp02@...0000000 {
> + opp-hz = /bits/ 64 <1100000000>;
> + opp-microvolt = <1250000>;
> + clock-latency-ns = <140000>;
> + };
> + opp03@...0000000 {
> + opp-hz = /bits/ 64 <1000000000>;
> + opp-microvolt = <1100000>;
> + clock-latency-ns = <140000>;
> + };
> + opp04@...000000 {
> + opp-hz = /bits/ 64 <900000000>;
> + opp-microvolt = <1100000>;
> + clock-latency-ns = <140000>;
> + };
> + opp05@...000000 {
> + opp-hz = /bits/ 64 <800000000>;
> + opp-microvolt = <1100000>;
> + clock-latency-ns = <140000>;
> + };
> + opp06@...000000 {
> + opp-hz = /bits/ 64 <700000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <140000>;
> + };
> + opp07@...000000 {
> + opp-hz = /bits/ 64 <600000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <140000>;
> + };
> + opp08@...000000 {
> + opp-hz = /bits/ 64 <500000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <140000>;
> + };
> + opp09@...000000 {
> + opp-hz = /bits/ 64 <400000000>;
> + opp-microvolt = <1000000>;
> + clock-latency-ns = <140000>;
> + };
> + opp10@...000000 {
> + opp-hz = /bits/ 64 <300000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <140000>;
> + };
> + opp11@...000000 {
> + opp-hz = /bits/ 64 <200000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <140000>;
> + };
> + };
> };
>
> +&cpu0 { operating-points-v2 = <&cpu0_opp_table>; };
> +&cpu1 { operating-points-v2 = <&cpu0_opp_table>; };
> +&cpu2 { operating-points-v2 = <&cpu0_opp_table>; };
> +&cpu3 { operating-points-v2 = <&cpu0_opp_table>; };
> +
> +&cpu4 { operating-points-v2 = <&cpu1_opp_table>; };
> +&cpu5 { operating-points-v2 = <&cpu1_opp_table>; };
> +&cpu6 { operating-points-v2 = <&cpu1_opp_table>; };
> +&cpu7 { operating-points-v2 = <&cpu1_opp_table>; };
> +
Why? These are set by exynos5420.dtsi already, aren't they?
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists