linux-kernel - Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bna1d9js.fsf@eliezer.anholt.net>
Date:	Mon, 07 Dec 2015 17:16:23 -0800
From:	Eric Anholt <eric@...olt.net>
To:	Emil Velikov <emil.l.velikov@...il.com>
Cc:	ML dri-devel <dri-devel@...ts.freedesktop.org>,
	"Linux-Kernel\@Vger. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls.

Emil Velikov <emil.l.velikov@...il.com> writes:

> Hi Eric,
>
> A couple of suggestions/requests on the UAPI header side
>
> On 1 December 2015 at 20:35, Eric Anholt <eric@...olt.net> wrote:
>
>> --- /dev/null
>> +++ b/include/uapi/drm/vc4_drm.h
>
>> +#include <drm/drm.h>
>> +
> Can we make this a "drm.h" ?

Nope.

include/uapi/drm/vc4_drm.h:27:17: fatal error: drm.h: No such file or directory

and none of the drivers do, either.

>> +struct drm_vc4_create_bo {
>> +       uint32_t size;
>> +       uint32_t flags;
>> +       /** Returned GEM handle for the BO. */
>> +       uint32_t handle;
>> +       uint32_t pad;
> ... and not use the stdint.h types but __{s,u}* through the file.
>
> I'd rather than not nag why we want/need those, but if you prefer I
> can repeat myself/others.

I've switched to using the special types.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)