linux-kernel - Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Dec 2015 12:56:22 +0100
From:	Vegard Nossum <vegard.nossum@...il.com>
To:	"Suzuki K. Poulose" <Suzuki.Poulose@....com>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Marc Zyngier <marc.zyngier@....com>, Tejun Heo <tj@...nel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error

On 8 December 2015 at 11:08, Suzuki K. Poulose <Suzuki.Poulose@....com> wrote:
> On 08/12/15 07:58, Al Viro wrote:
>>
>> On Mon, Dec 07, 2015 at 10:49:05AM -0800, Linus Torvalds wrote:
>>>
>>> On Mon, Dec 7, 2015 at 10:05 AM, Suzuki K. Poulose
>>> <suzuki.poulose@....com> wrote:
>
>
> ...
>
>> Anyway, the fix for 9p bogosity follows; it definitely fixes a bug there,
>> and I'm fairly sure that it fixes the bug that had been reported.
>> A confirmation would be nice, of course...
>>
>> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
>> ---
>> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
>> index 699941e..5110785 100644
>> --- a/fs/9p/vfs_inode.c
>> +++ b/fs/9p/vfs_inode.c
>> @@ -451,9 +451,9 @@ void v9fs_evict_inode(struct inode *inode)
>>   {
>>         struct v9fs_inode *v9inode = V9FS_I(inode);
>>
>> -       truncate_inode_pages_final(inode->i_mapping);
>> +       truncate_inode_pages_final(&inode->i_data);
>>         clear_inode(inode);
>> -       filemap_fdatawrite(inode->i_mapping);
>> +       filemap_fdatawrite(&inode->i_data);
>>
>>         v9fs_cache_inode_put_cookie(inode);
>>         /* clunk the fid stashed in writeback_fid */
>>
>
> This patch fixes the problem :
>
> Tested-by: Suzuki K. Poulose <suzuki.poulose@....com>
>
> Thanks
> Suzuki

FWIW, I think I reported the same issue here:

http://sourceforge.net/p/v9fs/mailman/message/34661239/

And Al's patch fixed it here too. Thanks,


Vegard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/