linux-kernel - Re: [PATCH v3 2/4] clk: bcm2835: Support for clock parent selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <876109d8tn.fsf@eliezer.anholt.net>
Date:	Mon, 07 Dec 2015 17:32:04 -0800
From:	Eric Anholt <eric@...olt.net>
To:	Remi Pommarel <repk@...plefau.lt>,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Rob Herring <robh+dt@...nel.org>
Cc:	linux-rpi-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org, Remi Pommarel <repk@...plefau.lt>
Subject: Re: [PATCH v3 2/4] clk: bcm2835: Support for clock parent selection

Remi Pommarel <repk@...plefau.lt> writes:

> Some bcm2835 clocks used by hardware (like "PWM" or "H264") can have multiple
> parent clocks. These clocks divide the rate of a parent which can be selected by
> setting the proper bits in the clock control register.
>
> Previously all these parents where handled by a mux clock. But a mux clock
> cannot be used because updating clock control register to select parent needs a
> password to be xor'd with the parent index.
>
> This patch get rid of mux clock and make these clocks handle their own parent,
> allowing them to select the one to use.

I see, you use the new flag now in this patch.  I take back the comment
on the previous patch.

Patches 1-3 are:

Reviewed-by: Eric Anholt <eric@...olt.net>

and I think they're ready to go in the clock tree, even while the DT for
setting up the bcm2835-pwm driver is being reviewed on the DT list.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)