linux-kernel - Re: [PATCH V2] ARM: SWP emulation: Restore original *data when failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5666D00E.1000301@arm.com>
Date:	Tue, 08 Dec 2015 12:41:50 +0000
From:	Vladimir Murzin <vladimir.murzin@....com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	Shengjiu Wang <shengjiu.wang@...escale.com>,
	"ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>,
	"nico@...aro.org" <nico@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2] ARM: SWP emulation: Restore original *data when failed

On 08/12/15 10:44, Russell King - ARM Linux wrote:
> On Tue, Dec 08, 2015 at 10:22:53AM +0000, Vladimir Murzin wrote:
>> On 15/10/15 10:30, Shengjiu Wang wrote:
>>> __user_swpX_asm maybe failed in first STREX operation, emulate_swpX
>>> will try again, but the *data has been changed in first time. which
>>> causes the result is wrong.
>>> This patch is to fix this issue. When STREX succeed, change the *data.
>>> if it fail, *data is not changed.
>>>
>>> Signed-off-by: Shengjiu Wang <shengjiu.wang@...escale.com>
>>> ---
>>>  arch/arm/kernel/swp_emulate.c | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm/kernel/swp_emulate.c b/arch/arm/kernel/swp_emulate.c
>>> index 5b26e7e..c3fe769d 100644
>>> --- a/arch/arm/kernel/swp_emulate.c
>>> +++ b/arch/arm/kernel/swp_emulate.c
>>> @@ -36,10 +36,10 @@
>>>   */
>>>  #define __user_swpX_asm(data, addr, res, temp, B)		\
>>>  	__asm__ __volatile__(					\
>>> -	"	mov		%2, %1\n"			\
>>> -	"0:	ldrex"B"	%1, [%3]\n"			\
>>> -	"1:	strex"B"	%0, %2, [%3]\n"			\
>>> +	"0:	ldrex"B"	%2, [%3]\n"			\
>>> +	"1:	strex"B"	%0, %1, [%3]\n"			\
>>>  	"	cmp		%0, #0\n"			\
>>> +	"	moveq		%1, %2\n"			\
>>>  	"	movne		%0, %4\n"			\
>>>  	"2:\n"							\
>>>  	"	.section	 .text.fixup,\"ax\"\n"		\
>>>
>>
>> I wonder what is status of this patch? I see that arm64 counterpart has
>> landed in mainline, but I didn't manage to track down this one - is it
>> because it never been submitted to patch system?
> 
> Most probably.
> 

I've just submitted (on behalf of Shengjiu) it as 8475/1 with assumption
you have no concerns about the patch.

Thanks
Vladimir

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/