linux-kernel - RE: [PATCH v3 03/18] clocksource: Add NPS400 timers driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB5PR02MB114169D551B609CFC6F13E53D6080@DB5PR02MB1141.eurprd02.prod.outlook.com>
Date:	Tue, 8 Dec 2015 13:00:23 +0000
From:	Noam Camus <noamc@...hip.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	"linux-snps-arc@...ts.infradead.org" 
	<linux-snps-arc@...ts.infradead.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Chris Metcalf" <cmetcalf@...hip.com>,
	Rob Herring <robh+dt@...nel.org>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>
Subject: RE: [PATCH v3 03/18] clocksource: Add NPS400 timers driver

From: Daniel Lezcano [mailto:daniel.lezcano@...aro.org] 
Sent: Friday, December 04, 2015 11:13 AM


>It would be cleaner to define a fixed clock and then add a phandle in the DT.

>	timer_clk: timer_clk {
>		#clock-cells = <0>;
>		compatible = "fixed-clock";
>		clock-frequency = <123456789>;
>	};

>	timer {
>		compatible = "ezchip,nps400-timer";
>		clocks = <&timer_clk>;
>	}

>That will result in the same code than the other drivers.

>	clk = of_clk_get(np, 0);
>	if (IS_ERR(clk)) {
>		pr_err("%s: invalid clock\n", np->full_name);
>		return;
>	}

>  	rate = clk_get_rate(clk);

Seem like my driver comes before "fixed-clock" driver so I failed since I got no clocksource provider.
How can this be solved?

-Noam