linux-kernel - Re: [PATCH] mips: mm: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 08 Dec 2015 21:01:07 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
	Minchan Kim <minchan@...nel.org>
Subject: Re: [PATCH] mips: mm: fix build failure

On 12/7/15 20:09, Sudip Mukherjee wrote:
> We are having build failure with mips defconfig with the error:
> "MADV_FREE" redefined.
> 
> commit d53d95838c7d introduced uniform values for all architecture but
> missed removing the old value.
> 

What you said is OK to me. For me, one fix patch for all related archs
is enough (need not send several patches for each arch). :-)


Thanks.

> Fixes: d53d95838c7d ("arch/*/include/uapi/asm/mman.h: : let MADV_FREE have same value for all architectures")
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
> 
> build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/95309512
> 
>  arch/mips/include/uapi/asm/mman.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/uapi/asm/mman.h b/arch/mips/include/uapi/asm/mman.h
> index b0ebe59..ccdcfcb 100644
> --- a/arch/mips/include/uapi/asm/mman.h
> +++ b/arch/mips/include/uapi/asm/mman.h
> @@ -73,7 +73,6 @@
>  #define MADV_SEQUENTIAL 2		/* expect sequential page references */
>  #define MADV_WILLNEED	3		/* will need these pages */
>  #define MADV_DONTNEED	4		/* don't need these pages */
> -#define MADV_FREE	5		/* free pages only if memory pressure */
>  
>  /* common parameters: try to keep these consistent across architectures */
>  #define MADV_FREE	8		/* free pages only if memory pressure */
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/