linux-kernel - Re: [PATCH] mfd: da9063: Allow modular build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151208135607.GI3384@x1>
Date:	Tue, 8 Dec 2015 13:56:07 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Geert Uytterhoeven <geert+renesas@...der.be>
Cc:	Support Opensource <support.opensource@...semi.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: da9063: Allow modular build

On Mon, 07 Dec 2015, Geert Uytterhoeven wrote:

> Allow support for the DA9063 PMIC to be modular, cfr. DA9062, which
> allows to decrease size of multi-platform kernels (e.g.
> multi_v7_defconfig).
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The DA9063 driver appears to contain all module code.  In fact, I'm
surprised that it wasn't enabled for tristate in the first place.

In any case, it would be good to get a Reviewed/Acked-by from one of
the Dialog guys.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 4d92df6ef9fe92ac..527ee7168617c933 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -211,7 +211,7 @@ config MFD_DA9062
>  	  of the device.
>  
>  config MFD_DA9063
> -	bool "Dialog Semiconductor DA9063 PMIC Support"
> +	tristate "Dialog Semiconductor DA9063 PMIC Support"
>  	select MFD_CORE
>  	select REGMAP_I2C
>  	select REGMAP_IRQ

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/