linux-kernel - Re: [PATCH 1/5] dma: do not use 0x in front of %pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151208144839.GA24928@ulmo>
Date:	Tue, 8 Dec 2015 15:48:39 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	"Dmitry V. Krivenok" <krivenok.dmitry@...il.com>,
	linux-kernel@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Ross Zwisler <ross.zwisler@...ux.intel.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Rob Herring <robh+dt@...nel.org>,
	Frank Rowand <frowand.list@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Ray Jui <rjui@...adcom.com>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	linux-next@...r.kernel.org
Subject: Re: [PATCH 1/5] dma: do not use 0x in front of %pad

On Tue, Dec 01, 2015 at 10:01:52AM +0100, Nicolas Ferre wrote:
> Le 30/11/2015 21:45, Dmitry V. Krivenok a écrit :
> > Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@...il.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
> 
> > ---
> >  drivers/dma/at_hdmac_regs.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> > index 7f58f06..0474e4a 100644
> > --- a/drivers/dma/at_hdmac_regs.h
> > +++ b/drivers/dma/at_hdmac_regs.h
> > @@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {}
> >  static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
> >  {
> >  	dev_crit(chan2dev(&atchan->chan_common),
> > -		 "  desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n",
> > +		 "  desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> >  		 &lli->saddr, &lli->daddr,
> >  		 lli->ctrla, lli->ctrlb, &lli->dscr);

Hi Vinod,

I think this ended up being misapplied, possibly because the patch
doesn't seem to have been based on something upstream. I got build
warnings during sanity builds of linux-next today and applied this
patch to fix them. Feel free to squash it into the original patch.

Thierry

--->8---
diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
index 610907dbc11a..0474e4a0f02a 100644
--- a/drivers/dma/at_hdmac_regs.h
+++ b/drivers/dma/at_hdmac_regs.h
@@ -386,8 +386,8 @@ static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
 {
 	dev_crit(chan2dev(&atchan->chan_common),
 		 "  desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
-		 lli->saddr, lli->daddr,
-		 lli->ctrla, lli->ctrlb, lli->dscr);
+		 &lli->saddr, &lli->daddr,
+		 lli->ctrla, lli->ctrlb, &lli->dscr);
 }

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)