linux-kernel - Re: [PATCH 00/13] perf tools: Move perf subcommand framework into lib/tools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151208152915.GI11564@kernel.org>
Date:	Tue, 8 Dec 2015 12:29:15 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Josh Poimboeuf <jpoimboe@...hat.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] perf tools: Move perf subcommand framework into
 lib/tools

Em Tue, Dec 08, 2015 at 11:55:31AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Dec 08, 2015 at 11:52:33AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Dec 07, 2015 at 09:46:48AM +0100, Jiri Olsa escreveu:
> > > On Sun, Dec 06, 2015 at 02:02:42PM -0600, Josh Poimboeuf wrote:
> > > > I think the problem is that you have a stale version of the
> > > > auto-generated file llvm-src-base.c.  Looks like "make clean" doesn't
> > > > remove it.  I'll add a patch to fix it.
> 
> > > FYI I switched back to Arnaldo's perf/core and did 'make clean && make'
> > > which passed, then switched back to your change and build failed again
>  
> > Even after his patches, it doesn't work, but I think this time he is not
> > taking $(OUTPUT) into account, and as I do use "O=/tmp/build/perf/" it
> > fails, trying to fix this...
> 
> Nah, that was me not using O= for the 'make clean' call, after I do
> that, it works.
> 
> But its sad everytime we introduce the need to run 'make clean' to
> regain a clean build environment :-\

Ok, now trying to run:

 make -C tools/perf build-test

It fails here with:

[acme@...andy linux]$ cat ./tools/perf/make_clean_all_O
cd . && make -f Makefile O=/tmp/tmp.4iuuIJy0Ia DESTDIR=/tmp/tmp.EeBhrZY9H2 clean all
  CLEAN    libtraceevent
  CLEAN    libapi
  CLEAN    libbpf
  CLEAN    config
  CLEAN    feature
  CLEAN    tests
find: ‘/tmp/tmp.4iuuIJy0Ia/tests’: No such file or directory
make[4]: *** [tests-clean] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [clean] Error 2
[acme@...andy linux]$

This is after applying:

[acme@...andy perf]$ git log --oneline | head -3
dbb37aec117a perf tools: Use -iquote for local include paths
e32ac4f249a1 perf tools: Fix 'make clean'
a30c99a0beb3 Merge branch 'perf/urgent' into perf/core, to pick up fixes
[acme@...andy perf]$ 

-----------------------------------------------------------------------------------------------

[acme@...andy linux]$ ls -la /tmp/tmp.EeBhrZY9H2
total 4
drwx------.  2 acme acme    6 Dec  8 12:17 .
drwxrwxrwt. 26 root root 4096 Dec  8 12:17 ..
[acme@...andy linux]$ 
[acme@...andy linux]$ cd tools/perf
[acme@...andy perf]$ make -f Makefile O=/tmp/tmp.4iuuIJy0Ia DESTDIR=/tmp/tmp.EeBhrZY9H2 clean all
  CLEAN    libtraceevent
  CLEAN    libapi
  CLEAN    libbpf
  CLEAN    config
  CLEAN    feature
  CLEAN    tests
find: ‘/tmp/tmp.4iuuIJy0Ia/tests’: No such file or directory
make[1]: *** [tests-clean] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [clean] Error 2
[acme@...andy perf]$ 

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/