linux-kernel - Re: [PATCH] hfs: use list_for_each_entry in hfs_cat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1449594720.2689.1.camel@ubuntu-slavad-14.04>
Date:	Tue, 08 Dec 2015 09:12:00 -0800
From:	Vyacheslav Dubeyko <slava@...eyko.com>
To:	Geliang Tang <geliangtang@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hfs: use list_for_each_entry in hfs_cat_delete

On Tue, 2015-12-08 at 23:22 +0800, Geliang Tang wrote:
> Use list_for_each_entry() instead of list_for_each() to simplify
> the code.
> 

Looks good.

Reviewed-by: Vyacheslav Dubeyko <slava@...eyko.com>

Thanks,
Vyacheslav Dubeyko.

> Signed-off-by: Geliang Tang <geliangtang@....com>
> ---
>  fs/hfs/catalog.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/hfs/catalog.c b/fs/hfs/catalog.c
> index db458ee..1eb5d41 100644
> --- a/fs/hfs/catalog.c
> +++ b/fs/hfs/catalog.c
> @@ -214,7 +214,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str)
>  {
>  	struct super_block *sb;
>  	struct hfs_find_data fd;
> -	struct list_head *pos;
> +	struct hfs_readdir_data *rd;
>  	int res, type;
>  
>  	hfs_dbg(CAT_MOD, "delete_cat: %s,%u\n", str ? str->name : NULL, cnid);
> @@ -240,9 +240,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str)
>  		}
>  	}
>  
> -	list_for_each(pos, &HFS_I(dir)->open_dir_list) {
> -		struct hfs_readdir_data *rd =
> -			list_entry(pos, struct hfs_readdir_data, list);
> +	list_for_each_entry(rd, &HFS_I(dir)->open_dir_list, list) {
>  		if (fd.tree->keycmp(fd.search_key, (void *)&rd->key) < 0)
>  			rd->file->f_pos--;
>  	}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/