lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Dec 2015 12:35:28 -0500 From: Johannes Weiner <hannes@...xchg.org> To: Michal Hocko <mhocko@...nel.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, Minchan Kim <minchan@...nel.org>, "Kirill A. Shutemov" <kirill@...temov.name>, Vladimir Davydov <vdavydov@...allels.com>, linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>, Michal Hocko <mhocko@...e.com> Subject: Re: [PATCH mmotm] memcg: Ignore partial THP when moving task On Tue, Dec 08, 2015 at 06:13:09PM +0100, Michal Hocko wrote: > From: Michal Hocko <mhocko@...e.com> > > After "mm: rework mapcount accounting to enable 4k mapping of THPs" > it is possible to have a partial THP accessible via ptes. Memcg task > migration code is not prepared for this situation and uncharges the tail > page from the original memcg while the original THP is still charged via > the head page which is not mapped to the moved task. The page counter > of the origin memcg will underflow when the whole THP is uncharged later > on and lead to: > WARNING: CPU: 0 PID: 1340 at mm/page_counter.c:26 page_counter_cancel+0x34/0x40() > reported by Minchan Kim. > > This patch prevents from the underflow by skipping any partial THP pages > in mem_cgroup_move_charge_pte_range. PageTransCompound is checked when > we do pte walk. This means that a process might leave a partial THP > behind in the original memcg if there is no other process mapping it via > pmd but this is considered acceptable because it shouldn't happen often > and this is not considered a memory leak because the original THP is > still accessible and reclaimable. Moreover the task migration has always > been racy and never guaranteed to move all pages. > > Reported-by: Minchan Kim <minchan@...nel.org> > Acked-by: Johannes Weiner <hannes@...xchg.org> > Signed-off-by: Michal Hocko <mhocko@...e.com> > --- > > Hi, > this is a patch tested by Minchan in the original thread [1]. I have > only replaced PageCompound with PageTransCompound because other similar > fixes in mmotm used this one. The underlying implementation is the same. > Johannes, I have kept your a-b but let me know if you are not OK with the > changelog. Looks good to me, thanks Michal. Please keep my Acked-by. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists