linux-kernel - Re: [PATCH 10/34] x86, pkeys: arch-specific protection bitsy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1512081935290.3595@nanos>
Date:	Tue, 8 Dec 2015 19:35:56 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Dave Hansen <dave@...1.net>
cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org, x86@...nel.org,
	dave.hansen@...ux.intel.com
Subject: Re: [PATCH 10/34] x86, pkeys: arch-specific protection bitsy

On Tue, 8 Dec 2015, Thomas Gleixner wrote:
> On Tue, 8 Dec 2015, Dave Hansen wrote:
> 
> > Here's how it looks with the suggested modifications.
> > 
> > Whatever compiler wonkiness I was seeing is gone now, so I've used the
> > most straightforward version of the shifts.
> 
> > +        * gcc generates better code if we do this rather than:
> > +        * pkey = (flags & mask) >> shift
> > +        */
> > +       pkey = (vma->vm_flags & vma_pkey_mask) >> VM_PKEY_SHIFT;
> 
> ROTFL!

Other than that silly comment, it's way better than before.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/