linux-kernel - Re: [PATCH v2 01/14] perf: Fix 'make clean'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151208184926.GF14846@treble.redhat.com>
Date:	Tue, 8 Dec 2015 12:49:26 -0600
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v2 01/14] perf: Fix 'make clean'

On Tue, Dec 08, 2015 at 07:40:43PM +0100, Jiri Olsa wrote:
> On Tue, Dec 08, 2015 at 06:40:12PM +0100, Jiri Olsa wrote:
> > On Mon, Dec 07, 2015 at 10:21:39PM -0600, Josh Poimboeuf wrote:
> > > Add some missing files to the 'make clean' target.
> > > 
> > > Reported-by: Jiri Olsa <jolsa@...hat.com>
> > > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> > > ---
> > >  tools/perf/Makefile.perf | 13 +++++++++++--
> > >  1 file changed, 11 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > > index 929a32b..8b63dbd 100644
> > > --- a/tools/perf/Makefile.perf
> > > +++ b/tools/perf/Makefile.perf
> > > @@ -584,13 +584,22 @@ config-clean:
> > >  	$(call QUIET_CLEAN, config)
> > >  	$(Q)$(MAKE) -C $(srctree)/tools/build/feature/ clean >/dev/null
> > >  
> > > -clean: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean config-clean
> > > +feature-clean:
> > > +	$(call QUIET_CLEAN, feature)
> > > +	$(Q)$(RM) -r $(OUTPUT)feature
> > 
> > that should be within feature dir
> > 
> > > +
> > > +tests-clean:
> > > +	$(call QUIET_CLEAN, tests)
> > > +	$(Q)find $(OUTPUT)tests -name '*.o' -delete -o -name '\.*.cmd' -delete
> > 
> > hum, that'd be excuted twice (another one below)
> 
> it also crashes build test (make -f tests/make)

Thanks, I'll look into it.

> 
> jirka
> 
> [jolsa@...va perf]$ make -f tests/make make_clean_all_O
> Testing Makefile
> - make_clean_all_O: cd . && make -f Makefile O=/tmp/tmp.glBnmXFNzM DESTDIR=/tmp/tmp.S5f5hGWoVy clean all
> cd . && make -f Makefile O=/tmp/tmp.glBnmXFNzM DESTDIR=/tmp/tmp.S5f5hGWoVy clean all
>   CLEAN    libapi
>   CLEAN    libtraceevent
>   CLEAN    libbpf
>   CLEAN    config
>   CLEAN    feature
>   CLEAN    tests
> find: ‘/tmp/tmp.glBnmXFNzM/tests’: No such file or directory
> Makefile.perf:592: recipe for target 'tests-clean' failed
> make[3]: *** [tests-clean] Error 1
> make[3]: *** Waiting for unfinished jobs....
> Makefile:75: recipe for target 'clean' failed
> make[2]: *** [clean] Error 2
> tests/make:249: recipe for target 'make_clean_all_O' failed
> make[1]: *** [make_clean_all_O] Error 1
> tests/make:10: recipe for target 'make_clean_all_O' failed
> make: *** [make_clean_all_O] Error 2

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/