linux-kernel - Re: [PATCH 3/7] cgroup: introduce cgroup namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151208194600.GH30240@mtj.duckdns.org>
Date:	Tue, 8 Dec 2015 14:46:00 -0500
From:	Tejun Heo <tj@...nel.org>
To:	"Serge E. Hallyn" <serge.hallyn@...ntu.com>
Cc:	linux-api@...r.kernel.org, containers@...ts.linux-foundation.org,
	hannes@...xchg.org, linux-kernel@...r.kernel.org,
	ebiederm@...ssion.com, lxc-devel@...ts.linuxcontainers.org,
	gregkh@...uxfoundation.org, cgroups@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 3/7] cgroup: introduce cgroup namespaces

Hello, Serge.

On Tue, Dec 08, 2015 at 01:34:31PM -0600, Serge E. Hallyn wrote:
> > I'd prefer collecting all ns related declarations in a single place.
> 
> I can group some of them, but free_cgroup_ns needs the
> cgroup_namespace definition, put_cgroup_ns() needs free_cgroup_ns(),
> and free_cgroup_ns() is static in the !CONFIG_CGROUPS case and a
> non-static function in the other case.
> 
> So I'm going to put both get_cgroup_ns() and put_cgroup_ns() at the
> end of the file, with the struct namespace define at the top.  Is
> that sufficient?

I wouldn't even mind creating a separate #ifdef section for NS stuff
if that's wnat's necessary for collecting everything into one spot.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/