linux-kernel - Re: [PATCH] ACPI: Add phylib support code for mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <566735CF.30000@redhat.com>
Date:	Tue, 8 Dec 2015 12:55:59 -0700
From:	Al Stone <ahs3@...hat.com>
To:	Graeme Gregory <gg@...mlogic.co.uk>,
	yankejian <yankejian@...wei.com>
Cc:	rjw@...ysocki.net, lenb@...nel.org, davem@...emloft.net,
	liguozhu@...wei.com, yisen.zhuang@...wei.com,
	huangdaode@...ilicon.com, lipeng321@...wei.com,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	linuxarm@...wei.com
Subject: Re: [PATCH] ACPI: Add phylib support code for mdio

On 12/03/2015 03:47 AM, Graeme Gregory wrote:
> On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote:
>> Add support for getting the PHY devices on an MDIO bus by ACPI.
>> Currently many of the ethernet drivers are open coding a solution
>> for reading data out of ACPI to find the correct PHY device.
>> This patch implements a set of common routines are similar to of_mdio.c
>>
> 
> The general conclusion for the ACPI on ARM64 discussion so far has been that
> things like PHYs should be setup by the firmware before the kernel takes
> control.
> 
> I am unsure that this doing it the same way as DT with a different
> description language is the way to go.
> 
> Graeme

I have to agree with Graeme: if this is supposed to be an arm64 server using
ACPI, please make sure the PHYs/clocks/regulators are set up properly before
passing control to the kernel.  That's the consensus so far on how this is to
be done.

This also looks to be using _DSD in ACPI, which is another topic that's still
under discussion.  What does the ASL look like for these PHYs, as used in this
patch?

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@...hat.com
-----------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/