lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Dec 2015 16:52:22 -0600 From: "Serge E. Hallyn" <serge.hallyn@...ntu.com> To: Seth Forshee <seth.forshee@...onical.com> Cc: Alexander Viro <viro@...iv.linux.org.uk>, "Serge E. Hallyn" <serge@...lyn.com>, Theodore Ts'o <tytso@....edu>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] fs: Drop CAP_SYS_RAWIO requirement for FIBMAP On Sat, Dec 05, 2015 at 12:15:16AM -0600, Seth Forshee wrote: > The information exposed by FIBMAP is not privileged and is > similar to the information provided by FIEMAP, which does not > require privileges. According to [1] the reason the capability > check was originally added was to prevent crashing the kernel > by passing invalid arguments, but this should no longer be a > problem, so this requirement can be removed. > > [1] http://www.gossamer-threads.com/lists/linux/kernel/103611 > > Cc: "Serge E. Hallyn" <serge@...lyn.com> > Cc: Theodore Ts'o <tytso@....edu> > Signed-off-by: Seth Forshee <seth.forshee@...onical.com> Acked-by: Serge Hallyn <serge.hallyn@...onical.com> > --- > fs/ioctl.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ioctl.c b/fs/ioctl.c > index 5d01d2638ca5..c963d82b0de8 100644 > --- a/fs/ioctl.c > +++ b/fs/ioctl.c > @@ -55,8 +55,6 @@ static int ioctl_fibmap(struct file *filp, int __user *p) > /* do we support this mess? */ > if (!mapping->a_ops->bmap) > return -EINVAL; > - if (!capable(CAP_SYS_RAWIO)) > - return -EPERM; > res = get_user(block, p); > if (res) > return res; > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists