linux-kernel - Re: x86 fpu: command-line parameters broken post-FPU-rewrite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151209083209.GB15254@gmail.com>
Date:	Wed, 9 Dec 2015 09:32:10 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Dave Hansen <dave.hansen@...el.com>
Cc:	the arch/x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Yu, Yu-cheng" <yu-cheng.yu@...el.com>,
	"Yu, Fenghua" <fenghua.yu@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>
Subject: Re: x86 fpu: command-line parameters broken post-FPU-rewrite


* Dave Hansen <dave.hansen@...el.com> wrote:

> Hey Ingo,
> 
> We were starting to look at reenabling XSAVES support and tried to use the 
> 'noxsave' and 'noxsaves' kernel command-line options.  The rewrite moved the FPU 
> initialization to before we even are parsing command-line options, even the 
> early_param()s.
> 
> Do you have any preferences on how it gets fixed?
> 
> The most obvious thing would be to just defer as much of the FPU setup as we can 
> until after parse_early_param() has happened.  The only other think I can think 
> of doing would be to try to do some *really* early, simple, command-line parsing 
> to look for 'noxsave' and friends.
> 
> Thoughts?

Hm, so given that having the FPU operational is key to a functioning kernel (and 
other kernel subsystems may make use of FPU functionality), I'd rather bring 
option parsing earlier than change the FPU setup sequence. FPU setup should be 
done when we identify the CPU - not 'very late' as we used to.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/