lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Dec 2015 09:50:05 +0100 From: Sascha Hauer <s.hauer@...gutronix.de> To: John Stultz <john.stultz@...aro.org> Cc: Arnd Bergmann <arnd@...db.de>, lkml <linux-kernel@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Vinay Simha BN <simhavcs@...il.com>, Bjorn Andersson <bjorn.andersson@...ymobile.com>, Haojian Zhuang <haojian.zhuang@...aro.org>, devicetree@...r.kernel.org, Android Kernel Team <kernel-team@...roid.com> Subject: Re: [RFC][PATCH] misc: Introduce reboot_reason driver On Tue, Dec 08, 2015 at 04:13:35PM -0800, John Stultz wrote: > On Tue, Dec 8, 2015 at 1:52 PM, Arnd Bergmann <arnd@...db.de> wrote: > > > > On Tuesday 08 December 2015 13:29:22 John Stultz wrote: > > > > > diff --git a/arch/arm/boot/dts/qcom-apq8064-nexus7-flo.dts b/arch/arm/boot/dts/qcom-apq8064-nexus7-flo.dts > > > index 5183d18..ee5dcb7 100644 > > > --- a/arch/arm/boot/dts/qcom-apq8064-nexus7-flo.dts > > > +++ b/arch/arm/boot/dts/qcom-apq8064-nexus7-flo.dts > > > @@ -282,6 +282,15 @@ > > > }; > > > }; > > > > > > + reboot_reason: reboot_reason@...3f65c { > > > + compatible = "reboot_reason"; > > > > This is not a good compatible string. There should generally be a vendor > > name associated with it (use "linux," if nothing else, and you should have > > '-' instead of '_'. > > > Ack. > > > > > > > > > + reg = <0x2A03F65C 0x4>; > > > > This may easily conflict with the device it is part of. We should have > > non-overlapping register areas in general. For the example you are > > looking at, which register block is this? > > So Bjorn says its IMEM, but I was assuming it was just a reserved > magic phys addr from the bootloader. > > Ideally I'm hoping to use this same driver for another device, which > plans to reserve a page from memory that the bootloader won't clear. > > > > > +/* Types of reasons */ > > > +static enum { > > > + NONE, > > > + BOOTLOADER, > > > + RECOVERY, > > > + OEM, > > > + MAX_REASONS > > > +} __maybe_unused reason_types; > > > > The variable seems to always be unused, not just "__maybe_unused". Maybe remove it? > > > Yea. I initially just had the empty enum, but the compiler was giving > me "useless class storage specifier in empty declaration" warnings. So > I added a variable to it, but then I got unused variable warnings. So > I ended up with this. :P > > Is there a better way? Are enums for array indexes out of fashion? They are not, but you have declared a variable (reason_types) which you don't use. You probably meant to create a enum named reason_types, like this: enum reason_types { NONE, BOOTLOADER, RECOVERY, OEM, MAX_REASONS }; Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists