linux-kernel - Re: [PATCH 2/3] regmap: add 64-bit mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 09 Dec 2015 17:01:55 +0800
From:	Xiubo Li <lixiubo@...s.chinamobile.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	broonie@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] regmap: add 64-bit mode support



On 09/12/2015 16:45, Arnd Bergmann wrote:
> On Thursday 03 December 2015 17:31:52 Xiubo Li wrote:
>> @@ -2488,11 +2581,17 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val,
>>                                   * we assume that the values are native
>>                                   * endian.
>>                                   */
>> +                               u64 *u64 = val;
>>                                  u32 *u32 = val;
>>                                  u16 *u16 = val;
>>                                  u8 *u8 = val;
>>   
>>                                  switch (map->format.val_bytes) {
>> +#ifdef CONFIG_64BIT
>> +                               case 8:
>> +                                       u64[i] = ival;
>> +                                       break;
>> +#endif
>>                                  case 4:
>>                                          u32[i] = ival;
>>                                          break;
>>
> This now gives me:
>
> drivers/base/regmap/regmap.c: In function 'regmap_bulk_read':
> drivers/base/regmap/regmap.c:2584:10: warning: unused variable 'u64' [-Wunused-variable]
>       u64 *u64 = val;
>            ^
>
I will fix this.

Thanks for your catch.

BRs



> 	Arnd



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/