linux-kernel - Re: [Y2038] [PATCH 1/2] ppdev: convert to y2038 safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14664570.qCTxRETJS5@wuerfel>
Date:	Wed, 09 Dec 2015 10:45:39 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	y2038@...ts.linaro.org
Cc:	Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	broonie@...nel.org, sudipm.mukherjee@...il.com
Subject: Re: [Y2038] [PATCH 1/2] ppdev: convert to y2038 safe

On Wednesday 09 December 2015 14:11:37 Bamvor Jian Zhang wrote:
> The y2038 issue for ppdev is changes of timeval in the ioctl
> (PPSETTIME and PPGETTIME). The size of struct timeval changes from
> 8bytes to 16bytes due to the changes of time_t. It lead to the
> changes of the command of ioctl, e.g. for PPGETTIME, We have:
> 
> on 32-bit (old): 0x80087095
> on 32-bit (new): 0x80107095
> on 64-bit      : 0x80107095
> 
> This patch define these two ioctl commands to support the 32bit
> and 64bit time_t application at the same time. And, introduce
> pp_set_timeout to remove some duplicated code.
> 
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>

I've reviewed the previous versions in detail, and am happy with
the latest one.

Reviewed-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/