linux-kernel - Re: [tip:locking/core] sched/wait: Fix signal handling in bit wait helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zixkph0m.fsf@notabene.neil.brown.name>
Date:	Wed, 09 Dec 2015 12:06:33 +1100
From:	NeilBrown <nfbrown@...ell.com>
To:	Peter Zijlstra <peterz@...radead.org>,
	torvalds@...ux-foundation.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, efault@....de, mingo@...nel.org,
	hpa@...or.com, vladimir.murzin@....com
Cc:	linux-tip-commits@...r.kernel.org, jstancek@...hat.com,
	Oleg Nesterov <oleg@...hat.com>
Subject: Re: [tip:locking/core] sched/wait: Fix signal handling in bit wait helpers

On Tue, Dec 08 2015, Peter Zijlstra wrote:

>>  
>
> *sigh*, so that patch was broken.. the below might fix it, but please
> someone look at it, I seem to have a less than stellar track record
> here...

This new change seems to be more intrusive than should be needed.
Can't we just do:


 __sched int bit_wait(struct wait_bit_key *word)
 {
+	long state = current->state;
-	if (signal_pending_state(current->state, current))
-		return 1;
 	schedule();
+	if (signal_pending_state(state, current))
+		return -EINTR;
 	return 0;
 }

??

(and sorry for breaking this in the first place!)

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)