linux-kernel - Re: [PATCH v2 next 1/2] dts: hisi: fixes no syscon error when init mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <566807DC.8030107@huawei.com>
Date:	Wed, 9 Dec 2015 18:52:12 +0800
From:	"Yankejian (Hackim Yim)" <yankejian@...wei.com>
To:	Rob Herring <robh@...nel.org>
CC:	<davem@...emloft.net>, <pawel.moll@....com>,
	<mark.rutland@....com>, <ijc+devicetree@...lion.org.uk>,
	<galak@...eaurora.org>, <xuwei5@...ilicon.com>,
	<catalin.marinas@....com>, <will.deacon@....com>,
	<wangkefeng.wang@...wei.com>, <dingtianhong@...wei.com>,
	<liguozhu@...wei.com>, <Yisen.Zhuang@...wei.com>,
	<sboyd@...eaurora.org>, <haojian.zhuang@...aro.org>,
	<wangzhou1@...ilicon.com>, <bintian.wang@...wei.com>,
	<long.wanglong@...wei.com>, <leo.yan@...aro.org>,
	<haifeng.wei@...wei.com>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linuxarm@...wei.com>
Subject: Re: [PATCH v2 next 1/2] dts: hisi: fixes no syscon error when init
 mdio



On 2015/12/8 23:25, Rob Herring wrote:
> On Mon, Dec 07, 2015 at 04:25:06PM +0800, yankejian wrote:
>> Signed-nux start up, we get the log below:
>> "Hi-HNS_MDIO 803c0000.mdio: no syscon hisilicon,peri-c-subctrl
>>  mdio_bus mdio@...c0000: mdio sys ctl reg has not maped       "
>>
>> the source code about the subctrl is dealled with syscon, but dts doesn't.
> The source...
>
> s/dealled/dealt/
Thanks for pointing it out. it will be changed in patch v3.
Best Regards,
yankejian

>> it cause such fault. so this patch adds the syscon info on dts files to
>> fixes it. and it adds documentation for the devicetree bindings used by
> Capitalization please.

Thanks a lot for pointing it out. i will pay attention to that next time.
Best Regards,
yankejian
>> DT files of Hisilicon Hip05-D02 development board.
>>
>> Signed-off-by: yankejian <yankejian@...wei.com>
>> ---
>> change log:
>> v2:
>>  1) updates the related documented in the binding as well
>>  2) use the normal naming conventions using '-' instead of '_'
>>
>> v1:
>>  initial version
>> ---
>>  .../devicetree/bindings/arm/hisilicon/hisilicon.txt      | 16 ++++++++++++++++
>>  arch/arm64/boot/dts/hisilicon/hip05.dtsi                 |  5 +++++
>>  arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi             |  4 ++--
>>  3 files changed, 23 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>> index 6ac7c00..9f05767 100644
>> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>> @@ -187,6 +187,22 @@ Example:
>>  		reg = <0xb0000000 0x10000>;
>>  	};
>>  
>> +Hisilicon HiP05 PERISUB system controller
>> +
>> +Required properties:
>> +- compatible : "hisilicon,peri-c-subctrl", "syscon";
>> +- reg : Register address and size
>> +
>> +The HiP05 PERISUB system controller is shared by peripheral controllers in
>> +HiP05 Soc to implement some basic configurations. the peripheral
>> +controllers include mdio, ddr, iic, uart, timer and so on.
>> +
>> +Example:
>> +	/* for HiP05 PCIe-SAS system */
>> +	peri-c-subctrl: sub-ctrl-c@...00000 {
> s/sub-ctrl-c/syscon/
Thanks for pointing it out. it will be changed in patch v3.
Best Regards,
yankejian
>
>> +		compatible = "hisilicon,peri-c-subctrl", "syscon";
>> +		reg = <0x0 0x80000000 0x0 0x10000>;
>> +	};
>>  -----------------------------------------------------------------------
>>  Hisilicon CPU controller
>>  
>> diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
>> index 4ff16d0..5fec740 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
>> @@ -246,6 +246,11 @@
>>  			clock-frequency = <200000000>;
>>  		};
>>  
>> +		peri_c_subctrl: sub-ctrl-c@...00000 {
>> +			compatible = "hisilicon,peri-c-subctrl", "syscon";
>> +			reg = < 0x0 0x80000000 0x0 0x10000>;
>> +		};
>> +
>>  		uart0: uart@...00000 {
>>  			compatible = "snps,dw-apb-uart";
>>  			reg = <0x0 0x80300000 0x0 0x10000>;
>> diff --git a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
>> index 606dd5a..da7b6e6 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
>> @@ -10,8 +10,8 @@ soc0: soc@...000000 {
>>  		#address-cells = <1>;
>>  		#size-cells = <0>;
>>  		compatible = "hisilicon,hns-mdio";
>> -		reg = <0x0 0x803c0000 0x0 0x10000
>> -		       0x0 0x80000000 0x0 0x10000>;
>> +		reg = <0x0 0x803c0000 0x0 0x10000>;
>> +		subctrl-vbase = <&peri_c_subctrl>;
>>  
>>  		soc0_phy0: ethernet-phy@0 {
>>  			reg = <0x0>;
>> -- 
>> 1.9.1
>>
> .
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/