linux-kernel - Re: [PATCH v1] serial: core: support more baud rates when serial console setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151209120554.7d6153a5@lxorguk.ukuu.org.uk>
Date:	Wed, 9 Dec 2015 12:05:54 +0000
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	jslaby@...e.com, gregkh@...uxfoundation.org,
	rockchip-discuss@...omium.org
Subject: Re: [PATCH v1] serial: core: support more baud rates when serial
 console setup

On Wed,  9 Dec 2015 15:07:58 +0800
Jeffy Chen <jeffy.chen@...k-chips.com> wrote:

> Currently, when tring to set up a serial console with a higher
> baud rate, it would fallback to 921600.
> 
> So, add more baud rates to the baud rate array.
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>


Far simpler I think would be if we finally lost this old code and just did

	memset(&termios, 0, sizeof(struct termios));
	termios.c_cflag |= CREAD | HUPCL | CLOCAL;
	tty_termios_encode_baud_rate(&termios, baud, baud);


	if (bits == 7)
		..


and just removed the baud_rates table for good. The console drivers now
understand arbitrary rate requests and the core tty code has for years
supported doing the mapping for arbitrary baud rates as well as back
mapping them onto "classic" B9600 type encoding when possible.

That would also various devices with insane baud rates where someone was
too cheap to fit an extra crystal.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/