linux-kernel - Re: [PATCH] net : To avoid execution of extra instructions in NET RX path when rps_map is not set but rps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201512092311.UAnUPnDo%fengguang.wu@intel.com>
Date:	Thu, 10 Dec 2015 00:00:56 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Rahul Jain <rahul.jain@...sung.com>
Cc:	kbuild-all@...org, davem@...emloft.net, edumazet@...gle.com,
	ast@...mgrid.com, jiri@...lanox.com, daniel@...earbox.net,
	makita.toshiaki@....ntt.co.jp, noureddine@...sta.com,
	herbert@...dor.apana.org.au, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, k.ashutosh@...sung.com
Subject: Re: [PATCH] net : To avoid execution of extra instructions in NET RX
 path when rps_map is not set but rps_needed is true.

Hi Ashutosh,

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.4-rc4 next-20151209]

url:    https://github.com/0day-ci/linux/commits/Rahul-Jain/net-To-avoid-execution-of-extra-instructions-in-NET-RX-path-when-rps_map-is-not-set-but-rps_needed-is-true/20151209-183932
config: m68k-m5208evb_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

   net/core/dev.c: In function 'netif_rx_internal':
>> net/core/dev.c:3535:48: error: 'struct net_device' has no member named '_rx'
     struct netdev_rx_queue *dev_rxqueue = skb->dev->_rx;
                                                   ^
   net/core/dev.c:3535:26: warning: unused variable 'dev_rxqueue' [-Wunused-variable]
     struct netdev_rx_queue *dev_rxqueue = skb->dev->_rx;
                             ^
   net/core/dev.c: In function 'netif_receive_skb_internal':
   net/core/dev.c:3992:48: error: 'struct net_device' has no member named '_rx'
     struct netdev_rx_queue *dev_rxqueue = skb->dev->_rx;
                                                   ^
   net/core/dev.c:3992:26: warning: unused variable 'dev_rxqueue' [-Wunused-variable]
     struct netdev_rx_queue *dev_rxqueue = skb->dev->_rx;
                             ^

vim +3535 net/core/dev.c

  3529		return NET_RX_DROP;
  3530	}
  3531	
  3532	static int netif_rx_internal(struct sk_buff *skb)
  3533	{
  3534		int ret;
> 3535		struct netdev_rx_queue *dev_rxqueue = skb->dev->_rx;
  3536	
  3537		net_timestamp_check(netdev_tstamp_prequeue, skb);
  3538	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (7435 bytes)