linux-kernel - Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Dec 2015 10:50:09 -0600
From:	Scott Wood <scottwood@...escale.com>
To:	Borislav Petkov <bp@...e.de>, Michael Ellerman <mpe@...erman.id.au>
CC:	<linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	<linux-next@...r.kernel.org>,
	Johannes Thumshirn <jthumshirn@...e.de>
Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference
 counting" (was Re: linux-next: Tree for Dec 8)

On Wed, 2015-12-09 at 17:03 +0100, Borislav Petkov wrote:
> On Wed, Dec 09, 2015 at 12:17:47PM +0100, Borislav Petkov wrote:
> > On Wed, Dec 09, 2015 at 09:32:47PM +1100, Michael Ellerman wrote:
> > > Presumably caused by the fact that edac_init() is subsys_initcall(),
> > > whereas
> > > corenet_gen_publish_devices() is arch_initcall().
> > 
> > Thanks for the report!
> > 
> > Hmm, interesting, can you send .config please?
> > 
> > I need to fix this dependency properly - edac_core needs to have
> > finished loaded *before* any other EDAC driver loads. Every other order
> > is wrong.
> 
> Yeah, see Johannes' patch.
> 
> Btw, calling a driver's probe function from outside the driver is a new
> low in driver design. Tztztz...

It's not "a driver's probe function".  There is no driver whose .probe() is
mpc85xx_pci_err_probe() -- the name is historical.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/