linux-kernel - Re: [PATCH v2] powercap, intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151209085355.6442a508@icelake>
Date:	Wed, 9 Dec 2015 08:53:55 -0800
From:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Radivoje Jovanovic <radivoje.jovanovic@...el.com>,
	Seiichi Ikarashi <s.ikarashi@...fujitsu.com>,
	Mathias Krause <minipli@...glemail.com>,
	Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com>,
	jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check

On Wed,  9 Dec 2015 08:31:12 -0500
Prarit Bhargava <prarit@...hat.com> wrote:

> Intel RAPL initialized on several systems where the BIOS lock bit (msr
> 0x610, bit 63) was set.  This occured because the return value of
> rapl_read_data_raw() was being checked, rather than the value of the
> variable passed in, locked.
> 
> This patch properly implments the rapl_read_data_raw() call to check
> the variable locked, and now the Intel RAPL driver outputs the
> warning:
> 
> 	intel_rapl: RAPL package 0 domain package locked by BIOS
> 
> and does not initialize for the package.
> 
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
> Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> Cc: Radivoje Jovanovic <radivoje.jovanovic@...el.com>
> Cc: Seiichi Ikarashi <s.ikarashi@...fujitsu.com>
> Cc: Mathias Krause <minipli@...glemail.com>
> Cc: Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com>
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>
> 
> [v2]: fix brackets

Acked-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>

Good catch by Seiichi, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/