linux-kernel - Re: [PATCH] ARM: pxa: mark raumfeld init functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56685F60.6030200@zonque.org>
Date:	Wed, 9 Dec 2015 18:05:36 +0100
From:	Daniel Mack <daniel@...que.org>
To:	Arnd Bergmann <arnd@...db.de>, robert.jarzmik@...e.fr
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Haojian Zhuang <haojian.zhuang@...il.com>
Subject: Re: [PATCH] ARM: pxa: mark raumfeld init functions as __maybe_unused

On 12/09/2015 05:52 PM, Arnd Bergmann wrote:
> The raumfeld.c file contains three similar machine definitions,
> each with their own init function. If one or more of them are
> disabled, we get compile-time warnings:
> 
> arm/mach-pxa/raumfeld.c:1070:123: warning: 'raumfeld_connector_init' defined but not used [-Wunused-function]
> arm/mach-pxa/raumfeld.c:1082:123: warning: 'raumfeld_speaker_init' defined but not used [-Wunused-function]
> 
> This marks the functions as __maybe_unused to avoid the warnings.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Daniel Mack <daniel@...que.org>

Thanks!


> 
> diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
> index 0f67d94be297..8347d87a713d 100644
> --- a/arch/arm/mach-pxa/raumfeld.c
> +++ b/arch/arm/mach-pxa/raumfeld.c
> @@ -1046,7 +1046,7 @@ static void __init raumfeld_common_init(void)
>  	i2c_register_board_info(1, &raumfeld_pwri2c_board_info, 1);
>  }
>  
> -static void __init raumfeld_controller_init(void)
> +static void __init __maybe_unused raumfeld_controller_init(void)
>  {
>  	int ret;
>  
> @@ -1067,7 +1067,7 @@ static void __init raumfeld_controller_init(void)
>  	raumfeld_w1_init();
>  }
>  
> -static void __init raumfeld_connector_init(void)
> +static void __init __maybe_unused raumfeld_connector_init(void)
>  {
>  	pxa3xx_mfp_config(ARRAY_AND_SIZE(raumfeld_connector_pin_config));
>  	spi_register_board_info(ARRAY_AND_SIZE(connector_spi_devices));
> @@ -1079,7 +1079,7 @@ static void __init raumfeld_connector_init(void)
>  	raumfeld_common_init();
>  }
>  
> -static void __init raumfeld_speaker_init(void)
> +static void __init __maybe_unused raumfeld_speaker_init(void)
>  {
>  	pxa3xx_mfp_config(ARRAY_AND_SIZE(raumfeld_speaker_pin_config));
>  	spi_register_board_info(ARRAY_AND_SIZE(speaker_spi_devices));
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/