linux-kernel - Re: [PATCH net-next] cgroup: fix sock_cgroup_data initialization on earlier compilers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151209.150237.1395563395881100002.davem@davemloft.net>
Date:	Wed, 09 Dec 2015 15:02:37 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tj@...nel.org
Cc:	alaa@....mellanox.co.il, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] cgroup: fix sock_cgroup_data initialization
 on earlier compilers

From: Tejun Heo <tj@...nel.org>
Date: Wed, 9 Dec 2015 12:30:46 -0500

> sock_cgroup_data is a struct containing an anonymous union.
> sock_cgroup_set_prioidx() and sock_cgroup_set_classid() were
> initializing a field inside the anonymous union as follows.
> 
>  struct sock_ccgroup_data skcd_buf = { .val = VAL };
> 
> While this is fine on more recent compilers, gcc-4.4.7 triggers the
> following errors.
> 
>  include/linux/cgroup-defs.h: In function ‘sock_cgroup_set_prioidx’:
>  include/linux/cgroup-defs.h:619: error: unknown field ‘val’ specified in initializer
>  include/linux/cgroup-defs.h:619: warning: missing braces around initializer
>  include/linux/cgroup-defs.h:619: warning: (near initialization for ‘skcd_buf.<anonymous>’)
> 
> This is because .val belongs to the anonymous union nested inside the
> struct but the initializer is missing the nesting.  Fix it by adding
> an extra pair of braces.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Alaa Hleihel <alaa@....mellanox.co.il>
> Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")

Applied, thanks.