linux-kernel - Re: [PATCH 3/4] usb: host: ehci.h: remove duplicated return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151209202200.GA11593@kroah.com>
Date:	Wed, 9 Dec 2015 15:22:00 -0500
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Peter Senna Tschudin <peter.senna@...il.com>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-usb@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] usb: host: ehci.h: remove duplicated return

On Wed, Dec 09, 2015 at 05:15:43PM -0300, Geyslan G. Bem wrote:
> 2015-12-09 17:10 GMT-03:00 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:
> > Hello.
> >
> > On 12/09/2015 10:57 PM, Geyslan G. Bem wrote:
> >
> >> This patch removes the return of the default switch case, since
> >> 'ehci_port_speed()' already has the same default return.
> >>
> >> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> >> ---
> >>   drivers/usb/host/ehci.h | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> >> index 0daed80..49b91b6 100644
> >> --- a/drivers/usb/host/ehci.h
> >> +++ b/drivers/usb/host/ehci.h
> >> @@ -664,8 +664,8 @@ ehci_port_speed(struct ehci_hcd *ehci, unsigned int
> >> portsc)
> >>                 case 1:
> >>                         return USB_PORT_STAT_LOW_SPEED;
> >>                 case 2:
> >> +               /* fall through to default function return */
> >
> >
> >    We just don't need the above *case*.
> >
> >>                 default:
> >> -                       return USB_PORT_STAT_HIGH_SPEED;
> >
> >
> >    And n ow we don't need *dafault* too.
> 
> Case 1 only? If not low_speed, high_speed. So, I'll change it to a
> simple if branch.

No, please leave it as-is, it helps to understand what is going on here
easier.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/