lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 9 Dec 2015 13:03:43 -0800
From:	Harish Chegondi <harish.chegondi@...el.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...hat.com,
	Harish Chegondi <harish.chegondi@...il.com>,
	Andi Kleen <andi.kleen@...el.com>,
	Kan Liang <kan.liang@...el.com>,
	Lukasz Anaczkowski <lukasz.anaczkowski@...el.com>
Subject: Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU
 support



On 12/08/2015 01:07 AM, Peter Zijlstra wrote:
> On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote:
>> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void)
>>  		break;
>>  	case 61: /* Broadwell */
>>  		ret = bdw_uncore_pci_init();
>> +	case 87: /* Knights Landing */
>> +		ret = knl_uncore_pci_init();
>>  		break;
>>  	default:
>>  		return 0;
>> @@ -1289,6 +1300,8 @@ static int __init uncore_cpu_init(void)
>>  		break;
>>  	case 86: /* BDX-DE */
>>  		bdx_uncore_cpu_init();
>> +	case 87: /* Knights Landing */
>> +		knl_uncore_cpu_init();
>>  		break;
>>  	default:
> Surely you need some extra break statements in there?
> .
>
Yes, I missed the break statements. I will add the breaks in the next version of the patch.

Thanks for the review!

-Harish.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists