lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Dec 2015 16:38:06 -0500 From: Tejun Heo <tj@...nel.org> To: serge.hallyn@...ntu.com Cc: linux-kernel@...r.kernel.org, adityakali@...gle.com, linux-api@...r.kernel.org, containers@...ts.linux-foundation.org, cgroups@...r.kernel.org, lxc-devel@...ts.linuxcontainers.org, akpm@...ux-foundation.org, ebiederm@...ssion.com, gregkh@...uxfoundation.org, lizefan@...wei.com, hannes@...xchg.org, "Serge E. Hallyn" <serge.hallyn@...onical.com> Subject: Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path Hello, Serge. On Wed, Dec 09, 2015 at 01:28:54PM -0600, serge.hallyn@...ntu.com wrote: > +/* kernfs_node_depth - compute depth from @from to @to */ > +static size_t kernfs_depth(struct kernfs_node *from, struct kernfs_node *to) ... > +char *kernfs_path(struct kernfs_node *kn, char *buf, size_t buflen) > +{ > + return kernfs_path_from_node(NULL, kn, buf, buflen); > +} ... > diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h > index 5d4e9c4..d025ebd 100644 > --- a/include/linux/kernfs.h > +++ b/include/linux/kernfs.h > @@ -267,6 +267,9 @@ static inline bool kernfs_ns_enabled(struct kernfs_node *kn) > > int kernfs_name(struct kernfs_node *kn, char *buf, size_t buflen); > size_t kernfs_path_len(struct kernfs_node *kn); > +char * __must_check kernfs_path_from_node(struct kernfs_node *root_kn, > + struct kernfs_node *kn, char *buf, > + size_t buflen); I think I commented on the same thing before, but I think it'd make more sense to put @from after @to and the prototype is using @root_kn which is a bit confusing. Was converting the path functions to return length too much work? If so, that's fine but please explain what decisions were made. I skimmed through the series and spotted several other review points which didn't get addressed. Can you please go over the previous review cycle and address the review points? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists